-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12308/#review22814
-----------------------------------------------------------



trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/GenericResourceManagerObjectFactory.java
<https://reviews.apache.org/r/12308/#comment46530>

    Weird formatting changes?


- Chris Mattmann


On July 7, 2013, 8:44 p.m., Rajith Siriwardana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12308/
> -----------------------------------------------------------
> 
> (Updated July 7, 2013, 8:44 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-619
>     https://issues.apache.org/jira/browse/OODT-619
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Completed the implementation of GangliaResourceMonitor to provide load values 
> normalize between 0 and its capacity. initially added only 
> weightedAverageLoad calculation(load_one, load_five, load_fifteen).
> decisions: if a particular node is offline/not listed in the nodeMap/any 
> error occurred during getting the load value, then the node capacity will be 
> returned as the load value.one minute interval for updating the loadMap. 
> loadMap moved to GangliaResourceMonitor
> 
> modifications done to AssignmentMonitor,AssignmentMonitorFactory, 
> GenericResourcemanagementObjectFactory, resource.properties, 
> TestAssignmentMonitor, TestXmlRpcResourceManaber, 
> 
> 
> Diffs
> -----
> 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java
>  1500522 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitorFactory.java
>  1500522 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ResourceMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ResourceMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/exceptions/GangliaMonitorException.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/exceptions/MonitoringException.java
>  1500522 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/loadcalc/LoadCalculator.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/loadcalc/LoadCalculatorFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/loadcalc/WeightedAverageLoadCalc.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/loadcalc/WeightedAverageLoadCalcFactory.java
>  PRE-CREATION 
>   
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/util/GenericResourceManagerObjectFactory.java
>  1500522 
>   trunk/resource/src/main/resources/resource.properties 1500522 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonitor.java
>  1500522 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestGangliaResourceMonitor.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestGangliaXMLParser.java
>  1500522 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/utils/MockGmetad.java
>  PRE-CREATION 
>   
> trunk/resource/src/test/org/apache/oodt/cas/resource/system/TestXmlRpcResourceManager.java
>  1500522 
>   trunk/resource/src/testdata/gangliaXMLdump.xml 1500522 
>   trunk/resource/src/testdata/resourcemon/gangliaXMLdump.xml PRE-CREATION 
>   trunk/resource/src/testdata/resourcemon/nodes.xml PRE-CREATION 
>   trunk/resource/src/testdata/test.resource.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12308/diff/
> 
> 
> Testing
> -------
> 
> GangliaResourceMonitor test scenarios added to getLoad, removeNodeById, 
> updateLoad. Other test scenarios modified accordingly. 
> 
> 
> Thanks,
> 
> Rajith Siriwardana
> 
>

Reply via email to