Ross, Can you PLEASE make public any changes you have to filemgr? If we can get a test-by-test patch-fix then we are #winning. BTW I also have another local branch with various fixes. We also SHOULD NOT post calls to System.setProperties, as it makes it ultimately more difficult to debug when we wish to add/rremove/edit test cases for OODT. We should instead create a java.util.Properties() object, pump properties into there, then pass this to System.setProperties(properties).
Ross, can I please warn you not to touch to many test cases at the same time as this has been my downfall with regards to fixing this issue. We cannot fix everything at once. I have made this mistake over the last few months and do not want you to make it as well. If you fix ANY ONE test then please submit patch (as you are already doing perfectly) then we can merge. BTW apart from anything else a HUGE thank you for tackling this. It is a reasonable undertaking and OODT 0.7 will result directly from the stable tests we will achieve with this issue. Thank you SO much Ross. On Fri, Jul 25, 2014 at 11:04 AM, Rishi Verma <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23870/ > > Hi Ross, > > > So for example, for "src/test/resources/filemgr.properties", the first line > > above would be: > > URL url = this.getClass().getResource("/filemgr.properties"); > > I've tried the above in a few unit tests and it seems to work so far. I'll > > see if I can get a patch together. > > Yes, that looks great. Getting the resources straight from the build via > getResource is the way to go. Thank you Ross! > > > > - Rishi Verma > > On July 23rd, 2014, 11:33 p.m. UTC, Ross Laidlaw wrote: > Review request for oodt, Lewis McGibbney, Chris Mattmann, and Paul > Ramirez. > By Ross Laidlaw. > > *Updated July 23, 2014, 11:33 p.m.* > *Bugs: * OODT-685 <https://issues.apache.org/jira/browse/OODT-685> > *Repository: * oodt > Description > > After changes in the file manager directory structure for OODT-685, some of > the file manager unit tests required updating to point to the new location > for test resources (src/testdata moved to src/test/resources). > > This patch updates several of the file manager unit tests that referred to > src/testdata to point to src/test/resources instead. > > It also removes duplicate XML from the following test resources in > src/test/resources: cmd-line-actions.xml, cmd-line-options.xml and > product-types.xml. > > After applying the patch, there are still some issues when running file > manager tests (one test error and one test failure), see below for details. > > Testing > > Before applying the patch, the majority of file manager tests fail, as shown > by the results below: > > Tests run: 189, Failures: 74, Errors: 30, Skipped: 0 > > > > After applying the patch, the majority of file manager tests pass, except for > the following (1 failure, 1 error): > > Results : > > Failed tests: > > testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): > There aren't exactly 4 elements in the test samples! expected:<4> but > was:<11> > > Tests in error: > testAddProductType(org.apache.oodt.cas.filemgr.cli.TestFileManagerCli): > org.apache.oodt.cas.cli.exception.CmdLineConstructionException: Invalid > option: 'typeName' > > Diffs > > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestMappedDataSourceCatalog.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestOrderedDataSourceCatalog.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/datatransfer/TestLocalDataTransferer.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestCachedIngester.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestLocalCache.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestRmiCache.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestStdIngester.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/structs/type/TestTypeHandler.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManager.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManagerClient.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestExpImpCatalog.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestMetadataBasedProductMover.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestBasicVersioner.java > (1612886) > - > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestDateTimeVersioner.java > (1612886) > - /trunk/filemgr/src/test/resources/cmd-line-actions.xml (1612886) > - /trunk/filemgr/src/test/resources/cmd-line-options.xml (1612886) > - /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml > (1612886) > > View Diff <https://reviews.apache.org/r/23870/diff/> > -- *Lewis*
