----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24065/#review49194 -----------------------------------------------------------
Ship it! Ship It! - Lewis McGibbney On July 29, 2014, 8:13 p.m., Ross Laidlaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24065/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 8:13 p.m.) > > > Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and > Rishi Verma. > > > Bugs: OODT-722 > https://issues.apache.org/jira/browse/OODT-722 > > > Repository: oodt > > > Description > ------- > > Fixes tests in the 'repository' package for the file manager. There's a > single test class in the package called TestXMLRepositoryManager. This patch > makes a trivial change to the constructor so that it can locate the 'repomgr' > directory in the src/test/resources area. There aren't any > System.setProperty() calls in this test class so this is a straightforward > fix. > > > Diffs > ----- > > > /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java > 1614458 > > Diff: https://reviews.apache.org/r/24065/diff/ > > > Testing > ------- > > As described in OODT-722: > > > The following commands were used to run the tests: > > At top-level (trunk directory): > > mvn clean -Dtest=TestXMLRepositoryManager -DfailIfNoTests=false test -pl > filemgr -am > > > At module level (filemgr directory): > > mvn clean -Dtest=TestXMLRepositoryManager test > > > Test results before applying the patch: > --------------------------------------- > > Failed tests: > > testGetProductTypes(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > expected:<3> but was:<0> > > testGetProductTypeByName(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testGetProductTypeById(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadProductTypeWithMetadataWithBlankMet(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadProductTypeWithMetadataWithNoMet(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadProductTypeWithMetadata(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadBadFormattedDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadDescriptionTrimExplicitFalse(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadDescriptionTrimExplicitTrue(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadVersionerClass(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > testReadRepoPath(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > null > > Tests in error: > > testRepoPathEnvVarReplace(org.apache.oodt.cas.filemgr.repository.TestXMLRepositoryManager): > 0 > > Tests run: 12, Failures: 11, Errors: 1, Skipped: 0 > > > Test results after applying the patch: > -------------------------------------- > > Results : > > Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Ross Laidlaw > >
