----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26064/#review54766 -----------------------------------------------------------
Ship it! OK, after checking out trunk and applying the patch * tests pass 100% [INFO] OODT Core ......................................... SUCCESS [ 1.601 s] [INFO] Common Utilities .................................. SUCCESS [ 17.274 s] [INFO] CAS Command Line Interface ........................ SUCCESS [ 6.323 s] [INFO] Process Control System Input Data Package ......... SUCCESS [ 3.508 s] [INFO] Catalog and Archive Service Generic Multi-valued Metadata Container SUCCESS [ 5.200 s] [INFO] CAS Protocol ...................................... SUCCESS [ 5.899 s] [INFO] CAS Protocol FTP Implementation ................... SUCCESS [ 2.881 s] [INFO] CAS Protocol HTTP Implementation .................. SUCCESS [ 5.238 s] [INFO] CAS Protocol IMAPS Implementation ................. SUCCESS [ 3.270 s] [INFO] CAS Protocol SFTP Implementation .................. SUCCESS [ 3.477 s] [INFO] Query Expression .................................. SUCCESS [ 3.887 s] [INFO] OODT Single Sign On Security Package .............. SUCCESS [ 2.087 s] [INFO] Catalog and Archive File Management Component ..... SUCCESS [01:54 min] [INFO] OODT CAS Virtual Catalog and Integration Service. . SUCCESS [ 11.278 s] [INFO] Catalog and Archive Resource Management Component . SUCCESS [ 15.240 s] [INFO] Catalog and Archive Workflow Management Component . SUCCESS [ 26.693 s] [INFO] Catalog and Archive Crawling Framework ............ SUCCESS [ 11.449 s] [INFO] CAS Curation Interface ............................ SUCCESS [ 8.825 s] [INFO] CAS PGE Adaptor Framework ......................... SUCCESS [ 12.596 s] [INFO] CAS Installer Maven Mojo .......................... SUCCESS [ 2.283 s] [INFO] OODT :: Archetypes :: OpsUI ....................... SUCCESS [ 0.837 s] [INFO] OODT :: Archetypes :: RADiX ....................... SUCCESS [ 0.681 s] [INFO] OODT :: Archetypes ................................ SUCCESS [ 0.024 s] [INFO] CAS Push-Pull-Framework ........................... SUCCESS [ 16.337 s] [INFO] Product Service ................................... SUCCESS [ 3.268 s] [INFO] Profile Service ................................... SUCCESS [ 5.836 s] [INFO] OODT Web Grid ..................................... SUCCESS [ 6.210 s] [INFO] XML-configured, DBMS-based Product and Profile Server SUCCESS [ 6.743 s] [INFO] Apache OODT Configurable OPeNDAP Profile Server ... SUCCESS [ 16.545 s] [INFO] Process Control System Core Package ............... SUCCESS [ 7.856 s] [INFO] OODT Wicket Web Components ........................ SUCCESS [ 4.812 s] [INFO] CAS File Manager Browser Web App .................. SUCCESS [ 5.448 s] [INFO] CAS Product Server Web Application ................ SUCCESS [ 9.042 s] [INFO] CAS Workflow Manager Monitor Web App .............. SUCCESS [ 3.895 s] [INFO] Catalog and Archive File Management Browser ....... SUCCESS [ 6.457 s] [INFO] Catalog and Archive Workflow Management GUI Editor SUCCESS [ 9.696 s] [INFO] Process Control System Operator Interface Webapp .. SUCCESS [ 8.760 s] [INFO] OODT Process Control System JAX-RS service layer .. SUCCESS [ 9.631 s] [INFO] Apache OODT ....................................... SUCCESS [ 0.018 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 06:25 min [INFO] Finished at: 2014-09-27T12:18:01-08:00 [INFO] Final Memory: 68M/842M [INFO] ------------------------------------------------------------------------ * The Java documenration on the new class is absolutely killer... this is so helpful. * code formatting is all good for me * Generally a good patch... and extremely useful as well. Thanks for this - Lewis McGibbney On Sept. 26, 2014, 1:04 a.m., Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26064/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 1:04 a.m.) > > > Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and > Shakeh Khudikyan. > > > Bugs: OODT-754 > https://issues.apache.org/jira/browse/OODT-754 > > > Repository: oodt > > > Description > ------- > > This is a cleaned up version of the ProdTypePatternMetExtractor used at one > point at CHLA. Wrote some unit tests (and fixed a bug!). Made sure to write > some good javadocs and site docs too (they are basically the same as the > wiki). > > > Diffs > ----- > > trunk/CHANGES.txt 1627442 > trunk/metadata/pom.xml 1627442 > > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/AbstractSAXConfigReader.java > PRE-CREATION > > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/ProdTypePatternMetExtractor.java > PRE-CREATION > trunk/metadata/src/site/xdoc/user/basic.xml 1627442 > > trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestAbstractSAXConfigReader.java > PRE-CREATION > > trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestProdTypePatternMetExtractor.java > PRE-CREATION > trunk/metadata/src/testdata/product-type-patterns-2.xml PRE-CREATION > trunk/metadata/src/testdata/product-type-patterns.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/26064/diff/ > > > Testing > ------- > > 2 test classes, one for the SAX reader and one for the met extractor. > > (1) testExtractMetadata: Sanity check, make sure it works as advertised. > (2) testNewConfigFile: If a second config file is parsed, ignore the first > config file. > (3) testElementDeclarationOrder: The order of element declaration is > independent of the order of usage in the product-type template. > > > Thanks, > > Ricky Nguyen > >
