Dynamite Will review and commit most likely by EoD if all OK. On Fri, Apr 24, 2015 at 2:02 PM, Radu Manole <[email protected]> wrote:
> Hi, > I managed to make a diff file, for review board, but it had a problem with > applying the patch to pom.xml file. > So I created a pull request: > https://github.com/apache/oodt/pull/19 > > 2015-04-23 0:05 GMT+03:00 Lewis John Mcgibbney <[email protected] > >: > > > Can you please try generating the file with no formatting. > > Review Board works better with SvN compatible patches. If you cannot > apply > > your patch to an SVN codebase then you will most likely not be able to > > upload to Review board. > > Lewis > > > > On Wednesday, April 22, 2015, Radu Manole <[email protected]> > wrote: > > > > > Hi, > > > I tried to make a review on review board, but I got an error: > > > "The specified diff file could not be parsed. Line 8: No valid > separator > > > after the filename was found in the diff header" > > > I can try tomorrow, to make a github pull request if the problem > doesn't > > > have a solution. I attached the diff file in the meantime. > > > Waiting for your suggestions. > > > Thanks, > > > Radu. > > > > > > > > > 2015-04-22 3:27 GMT+03:00 Chris Mattmann <[email protected] > > > <javascript:_e(%7B%7D,'cvml','[email protected]');>>: > > > > > >> Yep and if you want to try Github, you can also do: > > >> > > >> http://github.com/apache/oodt/#contributing > > >> > > >> Pull request is fine after opening JIRA issue, or Review > > >> Board as Lewis mentioned. > > >> > > >> Cheers! > > >> Chris > > >> > > >> ------------------------ > > >> Chris Mattmann > > >> [email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');> > > >> > > >> > > >> > > >> > > >> -----Original Message----- > > >> From: Lewis John Mcgibbney <[email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> > > >> Reply-To: <[email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> > > >> Date: Tuesday, April 21, 2015 at 6:47 PM > > >> To: "[email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>" < > > >> [email protected] <javascript:_e(%7B%7D,'cvml','[email protected] > > ');> > > >> > > > >> Subject: Re: GSoC 2015 - Replace OODT's XMLPRC with Avro's RPC > > >> > > >> >Hey Radu, > > >> > > > >> >Good work :) > > >> > > > >> >On Tue, Apr 21, 2015 at 3:02 PM, Radu Manole < > [email protected] > > >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> > > >> >wrote: > > >> > > > >> >> Hi Chris, > > >> >> I made a Tika extractor for the file manager. How should I post the > > >> >>diff? A > > >> >> github pull request or attach a diff file to the jira item? > > >> >> > > >> > > > >> >Either or. Typically people here quite like review boards as well. > Can > > >> you > > >> >plea open one and link to it from the OODT Jira issue? > > >> >http://reviews.apache.org > > >> > > > >> > > > >> >> Also, is there a code conventions page? > > >> > > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/OODT/Getting+started+with+Apac > > >> > > > >he+OODT#GettingstartedwithApacheOODT-StepThree:UsingtheJIRAandDeveloping\ > > >> >Thanks > > >> >Lewis > > >> > > >> > > >> > > > > > > > -- > > *Lewis* > > > -- *Lewis*
