----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37701/#review97093 -----------------------------------------------------------
Ship it! Ship It! - Chris Mattmann On Aug. 27, 2015, 12:11 p.m., Radu Manole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37701/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 12:11 p.m.) > > > Review request for oodt, Lewis McGibbney and Chris Mattmann. > > > Repository: oodt > > > Description > ------- > > Modified the DaemonCrawler to use Avro RPC login instead of XML-RPC. > > > Diffs > ----- > > trunk/crawler/pom.xml 1693501 > trunk/crawler/src/main/avro/types/protocol.avdl PRE-CREATION > trunk/crawler/src/main/bin/crawlctl 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/action/CrawlerLauncherCliAction.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemonController.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroRpcCrawlerDaemon.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemon.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemonController.java > 1693501 > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/XmlRpcCrawlDaemonController.java > PRE-CREATION > > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/XmlRpcCrawlerDaemon.java > PRE-CREATION > > trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/DummyDaemonCrawler.java > PRE-CREATION > > trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/TestDaemonCrawler.java > PRE-CREATION > > trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/crawler/src/main/resources/bin/crawlctl > 1693501 > > trunk/pcs/core/src/main/java/org/apache/oodt/pcs/tools/PCSHealthMonitor.java > 1693501 > > Diff: https://reviews.apache.org/r/37701/diff/ > > > Testing > ------- > > No test was found for xmlrpc DaemonCrawler logic, so I made a > DummyAvroDaemonCrawler class to test only the rpc aspect of daemon crawler. > and created a class TestDaemonCrawler where I tested the connection and the > communication between AvroDaemonCrawler and AvroDaemonCrawlerController. > > > Thanks, > > Radu Manole > >
