Sterling effort Tom. Performing a lot better than England did in the Rugby World Cup these days..... Praise followed by a low blow. Yee ha. Boom
On Thursday, November 5, 2015, Tom Barber <tom.bar...@meteorite.bi> wrote: > True, but test coverage should also detect changes to the codebase and how > it behaves, not just prove that what you are currently writing isn't > broken.... as it transpires the aptly named TestXmlRpcWorkflowManagerClient > actually didn't test any of the XmlRpcWorkflowManagerClient methods, which > is great, should have checked that before possibly. > > Anyway, tidied up a few WM issues and written some tests to test a bunch of > the XMLRPC interface, I'll do the same for RM shortly. > > On Thu, Nov 5, 2015 at 2:44 PM, Chris Mattmann <mattm...@apache.org > <javascript:;>> wrote: > > > These weren’t interface issues. These are aesthetic improvements > > done piecemeal which depending on what day you pulled from trunk/master, > > it broke. > > > > Tests would be nice to uncover this inside of RM and WM - but note - this > > wasn’t a “bug” that existed before. It was a result of depending on a > > snapshot, > > so to each their own. > > > > But I love you still, Tom. > > > > — > > Chris Mattmann > > chris.mattm...@gmail.com <javascript:;> > > > > > > > > > > > > > > -----Original Message----- > > From: Tom Barber <tom.bar...@meteorite.bi <javascript:;>> > > Reply-To: <dev@oodt.apache.org <javascript:;>> > > Date: Thursday, November 5, 2015 at 2:39 AM > > To: "dev@oodt.apache.org <javascript:;>" <dev@oodt.apache.org > <javascript:;>> > > Subject: Re: Errors introduced into XML-RPC with recent HashMap/Hashtable > > stuff > > > > >Chill out! Although a reliance on a trunk build for another tool is > > >interesting, I'm clearing up the last of the interface issues. > > > > > >At the time I didn't realise that XMLRPC refused to work with hashmaps, > I > > >also didn't realise DRAT was an easy way to test trunk builds, would I > > >have > > >done this on a branch if I did it again? Absolutely. You learn something > > >new every day. So I apologise for the trunk instability. > > > > > >I never claimed cleaning up the code would be pain free but I have tried > > >to > > >validate all the changes against the test suite, clearly that isn't > > >enough. > > >Anyway, with Sonar down to 700 days I don't really have any plans to do > > >anything else major and had reverted to writing improved tests to cover > > >off > > >stuff, I had been looking at the file manager, but I guess the resource > > >manager and workflows could do with tests more than file manager as they > > >are clearly uncovered wrt to the changes I've made over the last few > days. > > > > > >On Thu, Nov 5, 2015 at 1:16 AM, Mattmann, Chris A (3980) < > > >chris.a.mattm...@jpl.nasa.gov <javascript:;>> wrote: > > > > > >> I think I may have to downgrade DRAT to 0.10. > > >> > > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> Chris Mattmann, Ph.D. > > >> Chief Architect > > >> Instrument Software and Science Data Systems Section (398) > > >> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > > >> Office: 168-519, Mailstop: 168-527 > > >> Email: chris.a.mattm...@nasa.gov <javascript:;> > > >> WWW: http://sunset.usc.edu/~mattmann/ > > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> Adjunct Associate Professor, Computer Science Department > > >> University of Southern California, Los Angeles, CA 90089 USA > > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> > > >> > > >> > > >> > > >> > > >> -----Original Message----- > > >> From: Tom Barber <tom.bar...@meteorite.bi <javascript:;>> > > >> Reply-To: "dev@oodt.apache.org <javascript:;>" <dev@oodt.apache.org > <javascript:;>> > > >> Date: Wednesday, November 4, 2015 at 4:12 PM > > >> To: "dev@oodt.apache.org <javascript:;>" <dev@oodt.apache.org > <javascript:;>> > > >> Subject: Re: Errors introduced into XML-RPC with recent > > >>HashMap/Hashtable > > >> stuff > > >> > > >> >Sorry, I fixed the tests the morning but didn't get a chance to check > > >>out > > >> >the uncovered stuff. I've updated resmgr and workflow to match the > > >>work I > > >> >did on filemgr earlier. I was actually writing some more basic tests > to > > >> >try > > >> >and cover that stuff off, I'll push that tomorrow if I get it done. > > >> > > > >> >Tom > > >> > > > >> >On Wed, Nov 4, 2015 at 11:38 PM, Mattmann, Chris A (3980) < > > >> >chris.a.mattm...@jpl.nasa.gov <javascript:;>> wrote: > > >> > > > >> >> Hi Tom, > > >> >> > > >> >> After your recent changes to 0.11-SNAPSHOT, I’m getting the > > >> >> following with DRAT: > > >> >> > > >> >> [chipotle:deploy/resmgr/bin] mattmann% ./resmgr-client --url > > >> >> http://localhost:9002 --operation --getNodes > > >> >> Nov 04, 2015 3:37:22 PM > > >> >> org.apache.oodt.cas.resource.system.XmlRpcResourceManagerClient > > >><init> > > >> >> INFO: Loading Resource Manager Configuration Properties from: > > >> >> [../etc/resource.properties] > > >> >> ERROR: Failed to get nodes : java.util.Hashtable cannot be cast to > > >> >> java.util.HashMap > > >> >> [chipotle:deploy/resmgr/bin] mattmann% > > >> >> > > >> >> > > >> >> Can you please fix ASAP? > > >> >> > > >> >> Chris > > >> >> > > >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> >> Chris Mattmann, Ph.D. > > >> >> Chief Architect > > >> >> Instrument Software and Science Data Systems Section (398) > > >> >> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > > >> >> Office: 168-519, Mailstop: 168-527 > > >> >> Email: chris.a.mattm...@nasa.gov <javascript:;> > > >> >> WWW: http://sunset.usc.edu/~mattmann/ > > >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> >> Adjunct Associate Professor, Computer Science Department > > >> >> University of Southern California, Los Angeles, CA 90089 USA > > >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> >> > > >> >> > > >> >> > > >> >> > > >> > > >> > > > > > > > -- *Lewis*
