[
https://issues.apache.org/jira/browse/OODT-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674117#comment-16674117
]
ASF GitHub Bot commented on OODT-998:
-------------------------------------
IMS94 closed pull request #74: OODT-998 Fix for "The startup script of
cas-filemgr fails if distribution is located in a path with blank spaces"
URL: https://github.com/apache/oodt/pull/74
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/filemgr/src/main/bin/filemgr b/filemgr/src/main/bin/filemgr
index 1a8c4164e..8981580c3 100644
--- a/filemgr/src/main/bin/filemgr
+++ b/filemgr/src/main/bin/filemgr
@@ -46,7 +46,7 @@ export PATH
## make sure that casfile manager has a run directory
## just to be on the safe side
-mkdir -p ${RUN_HOME}
+mkdir -p "${RUN_HOME}"
for file in `find ../lib/*.jar`; do
LIB_DEPS="${file}:${LIB_DEPS}"
@@ -73,19 +73,19 @@ case "$1" in
$JAVA_HOME/bin/java \
-cp ${LIB_DEPS} \
${DISTRIBUTED_CONF_PROPERTIES} \
- -Dlog4j.configurationFile=${FILEMGR_HOME}/etc/log4j2.xml \
-
-Djava.util.logging.config.file=${FILEMGR_HOME}/etc/logging.properties \
+ -Dlog4j.configurationFile="${FILEMGR_HOME}/etc/log4j2.xml" \
+
-Djava.util.logging.config.file="${FILEMGR_HOME}/etc/logging.properties" \
-Dorg.apache.oodt.cas.filemgr.properties=${CAS_FILEMGR_PROPS} \
org.apache.oodt.cas.filemgr.system.FileManagerServerMain \
--portNum $SERVER_PORT &
- echo $! > ${RUN_HOME}/cas.filemgr.pid
+ echo $! > "${RUN_HOME}/cas.filemgr.pid"
echo "OK"
sleep 5
;;
stop)
echo -n "Shutting down cas file manager: "
- kill `cat ${RUN_HOME}/cas.filemgr.pid`
- rm -f ${RUN_HOME}/cas.filemgr.pid
+ kill `cat "${RUN_HOME}/cas.filemgr.pid"`
+ rm -f "${RUN_HOME}/cas.filemgr.pid"
echo "OK"
;;
restart)
@@ -93,8 +93,8 @@ case "$1" in
$0 start
;;
status)
- if [ -e ${RUN_HOME}/cas.filemgr.pid ] ; then
- pid=`cat ${RUN_HOME}/cas.filemgr.pid`
+ if [ -e "${RUN_HOME}/cas.filemgr.pid" ] ; then
+ pid=`cat "${RUN_HOME}/cas.filemgr.pid"`
echo "cas filemgr is running with pid: $pid"
else
echo "cas filemgr is not running"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The startup script of cas-filemgr fails if distribution is located in a path
> with blank spaces
> ----------------------------------------------------------------------------------------------
>
> Key: OODT-998
> URL: https://issues.apache.org/jira/browse/OODT-998
> Project: OODT
> Issue Type: Bug
> Reporter: Madhawa Vidanapathirana
> Priority: Minor
>
> The script bin/filemgr of cas-filemgr fails if distribution is located in a
> path with space characters.
> E.g.
> # The distribution archive is extracted to _/home/user/Apache
> OODT/cas-filemgr-1.9-SNAPSHOT-dist_
> # The command _./filemgr start_ is executed from working directory
> _/home/user/Apache
> OODT/cas-filemgr-1.9-SNAPSHOT-dist/cas-filemgr-1.9-SNAPSHOT/bin_
> # The following output is observed.
> {noformat}
> Using standalone configuration management
> Starting cas file manager: OK
> Error: Could not find or load main class
> OODT.cas-filemgr-1.9-SNAPSHOT-dist.cas-filemgr-1.9-SNAPSHOT.etc.log4j2.xml{noformat}
> I will provide a fix for this issue soon. Already working on it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
