[ 
https://issues.apache.org/jira/browse/OOZIE-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453215#comment-13453215
 ] 

Virag Kothari commented on OOZIE-989:
-------------------------------------

Robert,
I see in the XTestCase.createCoordJob(), we have
{code}
coordJob.setStartTime(DateUtils.parseDateOozieTZ("2009-12-15T01:00Z"));
coordJob.setEndTime(DateUtils.parseDateOozieTZ("2009-12-17T01:00Z"));
{code}
Just changing this hardcoded time in the past to a time in future will solve 
many failures (all the ones mentioned in the JIRA description)
I prefer the above small change compared to both option (1) and option (2). As 
you saw, there are some testcases where startTime and endTime are specified. I 
think its better to fix them incrementally when they are seen failing. In this 
way, we dont have to stop the materialization service in test cases setting the 
start and end time of coordinator.



                
> Testcases failing intermittently where coordinator jobs are in catchup mode
> ---------------------------------------------------------------------------
>
>                 Key: OOZIE-989
>                 URL: https://issues.apache.org/jira/browse/OOZIE-989
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>
> When the coordinator jobs are in catchup mode, the CoordTriggerService may 
> pick those jobs and start materializing new actions for it. This may cause 
> conflict with the test case which is forcing a action to be added.
> For. eg., in most of the test cases, there is something like below where a 
> coordinator job and coordinator action are added.
> {code}
> int actionNum = 1;
>         CoordinatorJobBean job = 
> addRecordToCoordJobTable(CoordinatorJob.Status.RUNNING, false, false);
>         CoordinatorActionBean action = 
> addRecordToCoordActionTable(job.getId(), actionNum, 
> CoordinatorAction.Status.WAITING, "coord-action-get.xml", 0);
> {code}
> The materializationtrigger service may pick the RUNNING coord job and start 
> adding actions for it. This will cause the 'addRecordToCoordActionTable' to 
> fail as the action is already inserted in DB.
> Below are some links where this is happening:
> https://builds.apache.org/job/oozie-trunk-precommit-build/71/testReport/junit/org.apache.oozie.executor.jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor/testCoordActionPendingFalseStatusCountGet/
> https://builds.apache.org/job/oozie-trunk-precommit-build/86/testReport/junit/org.apache.oozie.executor.jpa/TestCoordJobGetActionsJPAExecutor/testCoordActionGet/
> https://builds.apache.org/job/oozie-trunk-precommit-build/85/testReport/junit/org.apache.oozie.executor.jpa/TestCoordJobGetReadyActionsJPAExecutor/testCoordActionGet/
> Also, most of the log information for this failing test cases is lost as 
> LocalOozie is used to start services. LocalOozie should not be used in test 
> cases unless required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to