[ 
https://issues.apache.org/jira/browse/OOZIE-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465914#comment-13465914
 ] 

Hadoop QA commented on OOZIE-999:
---------------------------------

Testing JIRA OOZIE-999

Cleaning local svn workspace

{code}
----------------------------

+1 PATCH_APPLIES
   CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
    +1 the patch does not introduce any @author tags
    +1 the patch does not introduce any tabs
    +1 the patch does not introduce any trailing spaces
    +1 the patch does not introduce any line longer than 132
    +1 the patch does adds/modifies 3 testcase(s)
+1 RAT
    +1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
    +1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
    +1 HEAD compiles
    +1 patch compiles
    +1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
    +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient 
annotations
    +1 the patch does not modify JPA files
+1 TESTS
   Tests run: 912
   Tests failures: 0
   Tests errors: 0
+1 DISTRO
    +1 distro tarball builds with the patch 

----------------------------
{code}

The full output of the test-patch run is available at

   https://builds.apache.org/job/oozie-trunk-precommit-build/114/
                
> XLogStreamer requires log4j.appender.oozie.layout.ConversionPattern to 
> contain a "-" (dash) or streaming logs to web UI and CLI don't work
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-999
>                 URL: https://issues.apache.org/jira/browse/OOZIE-999
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: trunk
>
>         Attachments: OOZIE-999.patch, OOZIE-999.patch
>
>
> XLogStreamer.constructPattern() contains:
> {code}
> StringBuilder sb = new StringBuilder();
> if (noFilter) {
>     sb.append("(.*)");
> }
> else {
>     sb.append("(.* - ");    // <----- Here's the dash
>     for (int i = 0; i < parameters.size(); i++) {
>         sb.append(parameters.get(i) + "\\[");
>         sb.append(filterParams.get(parameters.get(i)) + "\\] ");
>     }
>     sb.append(".*)");
> }
> filterPattern = Pattern.compile(sb.toString());
> {code}
> which causes streaming logs to the web UI and CLI to not work if 
> log4j.appender.oozie.layout.ConversionPattern in log4j.properties contains a 
> "-" (dash).  
> We should try to remove this restriction.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to