[
https://issues.apache.org/jira/browse/OOZIE-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472861#comment-13472861
]
Hadoop QA commented on OOZIE-1016:
----------------------------------
Testing JIRA OOZIE-1016
Cleaning local svn workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 912
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/139/
> Tests that use junit assert or fail in a new thread report success when they
> are actually failing
> -------------------------------------------------------------------------------------------------
>
> Key: OOZIE-1016
> URL: https://issues.apache.org/jira/browse/OOZIE-1016
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-1016.patch
>
>
> These three tests create a new thread and use junit methods (e.g.
> assertTrue(), fail(), etc). These tests report success even when they should
> be failing, which can be seen by looking in the log output.
> They all have something like this:
> {code}
> Thread testThread = new Thread() {
> public void run() {
> try {
> do some stuff
> assertTrue(something);
> ...
> {code}
> These are the three tests that do this:
> 1) {{org.apache.oozie.cli.TestValidation.testTimeout}}
> 2) {{org.apache.oozie.service.TestSchemaService.testWfSchemaFailure}}
> 3)
> {{org.apache.oozie.workflow.lite.TestLiteWorkflowAppParser.testWfValidationFailure}}
> All these tests are actually failing.
> The output from the first one is this:
> {code}
> Exception in thread "Thread-1" junit.framework.AssertionFailedError:
> expected:<-1> but was:<0> at
> junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at junit.framework.Assert.assertEquals(Assert.java:205)
> at org.apache.oozie.cli.TestValidation$1.run(TestValidation.java:51)
> {code}
> The second one has this:
> {code}
> Exception in thread "Thread-132" junit.framework.AssertionFailedError:
> Expected to catch ParseException but didn't encounter any at
> junit.framework.Assert.fail(Assert.java:50)
> at
> org.apache.oozie.service.TestSchemaService$1.run(TestSchemaService.java:148)
> {code}
> And the third one has this:
> {code}
> Exception in thread "Thread-132" junit.framework.AssertionFailedError:
> Expected to catch WorkflowException but didn't encounter any at
> junit.framework.Assert.fail(Assert.java:50)
> at
> org.apache.oozie.workflow.lite.TestLiteWorkflowAppParser$1.run(TestLiteWorkflowAppParser.java:345)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
