> On Oct. 26, 2012, 12:07 a.m., Mona Chitnis wrote: > > Thanks for uploading this Mohammad. > > > > In the unit tests, is it possible to add a check that the objects such as > > connection, consumer, producer etc are actually instantiated with the name > > "test-topic", in addition to not-null check?
It is a client-server setup. There is no easy way of testing the actually connection. We will need to setup pub-sub system which will be overkill. > On Oct. 26, 2012, 12:07 a.m., Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java, > > line 186 > > <https://reviews.apache.org/r/7740/diff/2/?file=180166#file180166line186> > > > > typo in spelling properties done > On Oct. 26, 2012, 12:07 a.m., Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java, > > line 194 > > <https://reviews.apache.org/r/7740/diff/2/?file=180166#file180166line194> > > > > same typo as above done - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7740/#review12802 ----------------------------------------------------------- On Oct. 26, 2012, 12:39 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7740/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2012, 12:39 a.m.) > > > Review request for oozie. > > > Description > ------- > > At first the patch will be committed to /branches/hcat-intre. When we will > feel comfortable for HCat integration, we will apply the patches into trunk. > > This task includes: > 1. Create/Manage JMS connections using user configured properties > 2. Create/Manage session for specific connection. > > > This addresses bug OOZIE-1032. > https://issues.apache.org/jira/browse/OOZIE-1032 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/trunk/core/pom.xml 1399483 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-default.xml > 1399483 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > PRE-CREATION > http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1399483 > > Diff: https://reviews.apache.org/r/7740/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > >
