----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7993/#review13314 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/7993/#comment28578> add javadoc branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/7993/#comment28579> add @Override tag branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java <https://reviews.apache.org/r/7993/#comment28580> if exception is caught e.g. URISyntaxException, include a fail("..") message in the catch block and pass the exception object. Same comment for other places too - Mona Chitnis On Nov. 9, 2012, 10:40 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7993/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2012, 10:40 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1059 > > changes include > 1. Add static method getHCatURI > 2. change PARTITION_SEPARATOR from semicolon to ampersand > 3. Add equals method > > > This addresses bug OOZIE-1059. > https://issues.apache.org/jira/browse/OOZIE-1059 > > > Diffs > ----- > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1407609 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1407609 > > Diff: https://reviews.apache.org/r/7993/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
