----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8022/#review13378 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/8022/#comment28663> Where is the input parameter 'dataInName' actually being used in this method? I think what you intended to do is StringBuilder uriTemplate = new StringBuilder(dataInName); Else, is there some other way that the mapping from dataInName to uriTemplate that takes place? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/8022/#comment28665> same as above http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/8022/#comment28666> same as above http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/8022/#comment28667> The diff of static method HCatURI.isHcatURI is missing in the patch http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java <https://reviews.apache.org/r/8022/#comment28668> unit tests are hard to understand quickly. Can a few comments be added? - Mona Chitnis On Nov. 13, 2012, 1:10 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8022/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 1:10 a.m.) > > > Review request for oozie. > > > Description > ------- > > Adding new functions > > > This addresses bug OOZIE-1061. > https://issues.apache.org/jira/browse/OOZIE-1061 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1408414 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/resources/oozie-default.xml > 1408414 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java > 1408414 > > Diff: https://reviews.apache.org/r/8022/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > >
