----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8137/#review13703 -----------------------------------------------------------
Very good work. is there any need to wait for other feature from HCat (for the time being). http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8137/#comment29377> will it be safe to test if 'pdms != null'. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8137/#comment29375> Try to add the partition information int he log message http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8137/#comment29376> ass an else block. write a log.debug() saying that one partition is updated. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8137/#comment29373> just log a message. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8137/#comment29374> same. log a message - Mohammad Islam On Nov. 21, 2012, 9:08 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8137/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2012, 9:08 a.m.) > > > Review request for oozie. > > > Description > ------- > > WIP patch. Waiting on functionality from HCatalog classes. Hence many //TODO > lines > > > This addresses bug OOZIE-1050. > https://issues.apache.org/jira/browse/OOZIE-1050 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1411968 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1411968 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageHandler.java > 1411968 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1411968 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1411968 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java > PRE-CREATION > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1411968 > > Diff: https://reviews.apache.org/r/8137/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
