----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8263/#review13880 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java <https://reviews.apache.org/r/8263/#comment29667> You do not need to type the class name again in the log statement. The Xlog class is taking care of adding that as suffix. Otherwise it will be too verbose and redundant. Applies to all such locations http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/8263/#comment29673> Which part is taking care of adding partition to PDMS missing Map after materialization and cold start check? I might have missed it http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8263/#comment29678> Log level should be INFO and not debug http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8263/#comment29675> Should also add printing the partition being dropped http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8263/#comment29677> Should also add printing the table being dropped http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java <https://reviews.apache.org/r/8263/#comment29674> typo - "unknown" http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8263/#comment29679> As a convention, private methods should begin with underscore e.g. _registerMessageReceiver http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/8263/#comment29681> Another TODO I would suggest is probably not queuing this DB command at each partitionAvailable call, but to batch them to reduce IO load on DB http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/8263/#comment29682> HCatURI's method getHCatURI appends "hcat://" at the beginning. then the partition looks like hcat://thrift://.... which to me looks confusing. But as long as the HCatURI's constructor properly checks scheme (which is the 'thrift' part), authority and port correctly, only for display purpose, the above string can be tolerated - Mona Chitnis On Nov. 29, 2012, 8:18 a.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8263/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 8:18 a.m.) > > > Review request for oozie. > > > Description > ------- > > This JIRa is to fix the issue found during integration. > > > This addresses bug OOZIE-1105. > https://issues.apache.org/jira/browse/OOZIE-1105 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/hcat/MetaDataClientWrapper.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorService.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > 1415073 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1415073 > > Diff: https://reviews.apache.org/r/8263/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > >
