----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8673/#review14769 -----------------------------------------------------------
looks good to me..few comments.. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31292> As dataOut uri is a single uri and not an array of URI, why not call the tofilter() of HcatURI directly. The createPartitionFilter does string operations which doesn't seem required for dataOut. branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31294> Can we have error handling when minPartition is null?..same comment for maxPartition el function branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31312> instead of doing substring and split to get rid of the first element of uriList, its better to have a for loop which doesn't read the first element. Same for max partition el function branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31291> I dont think arrray length can ever be 0. Can you check it? branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/8673/#comment31313> shouldn't the partition quotes be appended by the pig script (application) branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java <https://reviews.apache.org/r/8673/#comment31314> 1138 replaces all getServerEndpoint with getServer. Its better to keep this change in that patch branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java <https://reviews.apache.org/r/8673/#comment31316> add @Test annotations for all test cases - Virag Kothari On Dec. 20, 2012, 7 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8673/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2012, 7 p.m.) > > > Review request for oozie. > > > Description > ------- > > See https://issues.apache.org/jira/browse/OOZIE-1123 > All HCatalog related EL functions separated out into another class. Changed > nomenclature instead of having 'meta' > WIP - URIHandler to determine EL Functions to FS and HCat URIs and throw > error otherwise > > > This addresses bug OOZIE-1123. > https://issues.apache.org/jira/browse/OOZIE-1123 > > > Diffs > ----- > > branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java > PRE-CREATION > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1424233 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java > 1424233 > branches/hcat-intre/core/src/main/java/org/apache/oozie/util/XmlUtils.java > 1424233 > branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java > PRE-CREATION > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1424233 > > branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java > 1424233 > branches/hcat-intre/examples/src/main/apps/hcatalog/README PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/coordinator.xml > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/id.pig PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/job.properties > PRE-CREATION > branches/hcat-intre/examples/src/main/apps/hcatalog/workflow.xml > PRE-CREATION > branches/hcat-intre/pom.xml 1424233 > branches/hcat-intre/sharelib/hive/pom.xml 1424233 > > Diff: https://reviews.apache.org/r/8673/diff/ > > > Testing > ------- > > unit tests added. end-to-end test will be done using Pig job > > > Thanks, > > Mona Chitnis > >
