-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8679/#review14786
-----------------------------------------------------------



branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java
<https://reviews.apache.org/r/8679/#comment31359>

    typo for "queuing". Also make READY in caps



branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java
<https://reviews.apache.org/r/8679/#comment31371>

    Javadoc to understand this better



branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java
<https://reviews.apache.org/r/8679/#comment31373>

    this will always be true.You could another constructor that accepts boolean 
argument for patternMatch



branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
<https://reviews.apache.org/r/8679/#comment31369>

    what does this statement mean?



branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
<https://reviews.apache.org/r/8679/#comment31376>

    should be getAvailableMap().get(actionId1).size()


- Mona Chitnis


On Dec. 20, 2012, 2:53 a.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8679/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 2:53 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1138
> 
> 
> This addresses bug OOZIE-1138.
>     https://issues.apache.org/jira/browse/OOZIE-1138
> 
> 
> Diffs
> -----
> 
>   branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java 
> 1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/HCatMessageHandler.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/MessageReceiver.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
>  1424271 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java 
> PRE-CREATION 
>   
> branches/hcat-intre/core/src/main/java/org/apache/oozie/util/PartitionWrapper.java
>  1424271 
>   branches/hcat-intre/core/src/main/resources/oozie-default.xml 1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionUpdatePushMissingDependency.java
>  1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java
>  1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestHCatMessageHandler.java
>  1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/jms/TestMessageReceiver.java
>  1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java
>  1424271 
>   
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java
>  1424271 
> 
> Diff: https://reviews.apache.org/r/8679/diff/
> 
> 
> Testing
> -------
> 
> end to end test done and connections to jms server verified
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>

Reply via email to