----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8670/#review14920 -----------------------------------------------------------
branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/8670/#comment31958> missingDep could be null in new StringBuilder(missingDep); append INSTANCE_SEPARATOR only if missingDep is not null or empty i.e StringBuilder allDeps = new StringBuilder(); if(missingDep != null && !missingDep.isEmpty()) { allDeps.append(missingDep.split(INSTANCE_SEPARATOR)[0]); if(pushDeps != null && !pushDeps.isEmpty()) { allDeps.append(INSTANCE_SEPARATOR); } } branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/8670/#comment31960> Same as above. Extract logic to a new method getAllMissingDependencies(coordAction) as it is repeated twice in the class. - Rohini Palaniswamy On Dec. 26, 2012, 7:55 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8670/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2012, 7:55 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1135 > > > This addresses bug OOZIE-1135. > https://issues.apache.org/jira/browse/OOZIE-1135 > > > Diffs > ----- > > branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1425188 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1425188 > > Diff: https://reviews.apache.org/r/8670/diff/ > > > Testing > ------- > > unit test n/a. Test via submitting job and checking job -info -verbose on CLI > > > Thanks, > > Mona Chitnis > >
