> On Dec. 28, 2012, 12:56 a.m., Virag Kothari wrote: > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/utils/dbutils/updatescripts/dbscripts-3.2.0.sql, > > line 421 > > <https://reviews.apache.org/r/8770/diff/2/?file=243698#file243698line421> > > > > as we dont have create index scripts for other columns, we should skip > > having this here and in dbscripts-4.0.0.sql. > > its better to have it only for upgrade scripts.
Shouldn't the indexes also be part of the full db script? I was surprised that other indexes were not there. If there are more indexes, we should add them to the full script instead of removing them - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8770/#review14948 ----------------------------------------------------------- On Dec. 28, 2012, 12:42 a.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8770/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2012, 12:42 a.m.) > > > Review request for oozie. > > > Description > ------- > > Have marked the changes done from 3.1.0 script as comments. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/utils/dbutils/updatescripts/dbscripts-3.2.0.sql > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/utils/dbutils/updatescripts/dbscripts-4.0.0.sql > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/utils/dbutils/updatescripts/updatescripts-3.1.0-to-3.2.0.sql > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/utils/dbutils/updatescripts/updatescripts-3.2.0-to-4.0.0.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/8770/diff/ > > > Testing > ------- > > tested the create and alter statements on a oracle db. > > > Thanks, > > Rohini Palaniswamy > >
