----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8872/#review15152 -----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java <https://reviews.apache.org/r/8872/#comment32741> can availableDepList be renamed? These are still a from of missing deps right (since initialized using pushDepList) branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java <https://reviews.apache.org/r/8872/#comment32740> plz add a comment to explain what happens in this if block. It is unclear branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java <https://reviews.apache.org/r/8872/#comment32742> I dont see how wise it is to lock on job-id, since the private method getMissingDependencies invokes URIHandler.exists which is a remote call and is time-consuming - Mona Chitnis On Jan. 7, 2013, 11:52 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8872/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 11:52 p.m.) > > > Review request for oozie. > > > Description > ------- > > Patch for hcat-intre branch. > As OOZIE-1156 is not yet committed, some of its changes related to CoordPushX > are seen in this diff > > > This addresses bug OOZIE-1161. > https://issues.apache.org/jira/browse/OOZIE-1161 > > > Diffs > ----- > > > branches/hcat-intre/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1428524 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1428524 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1428524 > > branches/hcat-intre/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForModifiedTimeJPAExecutor.java > PRE-CREATION > > branches/hcat-intre/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForModifiedTimeJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8872/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
