[ 
https://issues.apache.org/jira/browse/OOZIE-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554803#comment-13554803
 ] 

Hadoop QA commented on OOZIE-945:
---------------------------------

Testing JIRA OOZIE-945

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 946
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/291/
                
> BundleSubmitXCommand.submit() doesn't properly remove comments
> --------------------------------------------------------------
>
>                 Key: OOZIE-945
>                 URL: https://issues.apache.org/jira/browse/OOZIE-945
>             Project: Oozie
>          Issue Type: Bug
>          Components: bundle
>            Reporter: Robert Kanter
>            Assignee: jun aoki
>            Priority: Minor
>         Attachments: oozie-945.2.patch, oozie-945.3.patch, oozie-945.4.patch, 
> oozie-945.patch
>
>
> Early in BundleSubmitXCommand.submit() there is this line:
> {code}
> XmlUtils.removeComments(this.bundleBean.getOrigJobXml().toString());
> {code}
> But removeComments() returns a String, so the resulting XML String with the 
> comments removed is never actually used by the rest of the code in submit()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to