----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8897/#review15579 -----------------------------------------------------------
Few comments discussed offline..also put below for tracking purpose trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/8897/#comment33661> Move this block to place where job is not successful. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/8897/#comment33662> As getActionData() does other stuff, retrieve only the external Ids here trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/8897/#comment33663> change signature of method by removing the first argument - Virag Kothari On Jan. 22, 2013, 10:56 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8897/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 10:56 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1160 > > > This addresses bug OOZIE-1160. > https://issues.apache.org/jira/browse/OOZIE-1160 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1436833 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1436833 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/OoziePigStats.java > 1436833 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1436833 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 1436833 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1436833 > trunk/webapp/src/main/webapp/oozie-console.js 1436833 > > Diff: https://reviews.apache.org/r/8897/diff/ > > > Testing > ------- > > e-2-e tested > > > Thanks, > > Mona Chitnis > >
