[ 
https://issues.apache.org/jira/browse/OOZIE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573855#comment-13573855
 ] 

Bowen Zhang commented on OOZIE-1054:
------------------------------------

Hi Alejandro, the issue with your code is that user cannot prepare war files 
and upload sharelib in the same run of oozie-setup.sh. Since you are using 
"${@}", you are jamming all the possible commands to the java class which was 
created with the intent to just do one thing.
My point is: if we allow users to create sharelib, prepare war files, and 
create db in one single setup.sh run, and we keep the current functionality of 
each java class without creating unnecessary parsing, then we need to parse all 
the subcommand and option values in setup.sh. Your above code works well when 
user is allowed to perform only one command in each run of setup.sh.
                
> Create script to properly upload sharelib to HDFS
> -------------------------------------------------
>
>                 Key: OOZIE-1054
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1054
>             Project: Oozie
>          Issue Type: New Feature
>          Components: scripts
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Bowen Zhang
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: oozie-1054.patch, oozie-1054.patch, oozie-1054.patch, 
> oozie-1054.patch, oozie-1054.patch, oozie-1054.patch, oozie-1054.patch, 
> oozie-1054.patch, oozie-1054.patch, oozie-1054.patch, oozie-1054.patch
>
>
> A common confusion-point for users is how to properly install the sharelib in 
> HDFS.  It would be really useful if we could create a script to properly 
> upload the sharelib to HDFS so we can get rid of the confusion around this.  
> Alternatively, instead of a new script, we could have the oozie-setup.sh 
> script take an argument that does this.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to