----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9414/#review16610 -----------------------------------------------------------
a few minor comments. http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/9414/#comment35239> a more proper name would be getFirstMissingDependency(..) http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml <https://reviews.apache.org/r/9414/#comment35240> same comment as before, why not activemq-client? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/URIHandler.java <https://reviews.apache.org/r/9414/#comment35242> this should be static, no? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java <https://reviews.apache.org/r/9414/#comment35244> can you explain this? http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml <https://reviews.apache.org/r/9414/#comment35238> there is an activemq-client, at least for 5.8.0. why not use that? - Alejandro Abdelnur On Feb. 12, 2013, 10:23 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9414/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2013, 10:23 p.m.) > > > Review request for oozie. > > > Description > ------- > > Review comments from OOZIE-1210. > > > This addresses bug OOZIE-1217. > https://issues.apache.org/jira/browse/OOZIE-1217 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1444831 > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/pom.xml > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/ErrorCode.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/action/hadoop/HCatLauncherURIHandler.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIContext.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/FSURIHandler.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIContext.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/URIContext.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/dependency/URIHandler.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/HCatAccessorException.java > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/HCatAccessorService.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/JMSAccessorService.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/MetaDataAccessorException.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/service/URIHandlerService.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/main/java/org/apache/oozie/util/MappingRule.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/core/src/test/java/org/apache/oozie/util/TestHCatURI.java > 1444831 > > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki > 1444831 > http://svn.apache.org/repos/asf/oozie/branches/hcat-intre/pom.xml 1444831 > > Diff: https://reviews.apache.org/r/9414/diff/ > > > Testing > ------- > > > Thanks, > > Rohini Palaniswamy > >
