> On Feb. 14, 2013, 9:04 p.m., Mona Chitnis wrote: > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java, > > line 121 > > <https://reviews.apache.org/r/9175/diff/3/?file=258600#file258600line121> > > > > so this means, from the command-line, we can pass comma-separated list > > of ids/appnames?
semi-colon separated list following convention of job filter, > On Feb. 14, 2013, 9:04 p.m., Mona Chitnis wrote: > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java, > > line 131 > > <https://reviews.apache.org/r/9175/diff/3/?file=258600#file258600line131> > > > > should combined logic be rather AND? this one still OR, since it translates to "where jobid in (ID1, ID2)" - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9175/#review16605 ----------------------------------------------------------- On Feb. 15, 2013, 8:32 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9175/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2013, 8:32 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1189 > > > This addresses bug OOZIE-1189. > https://issues.apache.org/jira/browse/OOZIE-1189 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1446424 > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1446424 > > trunk/core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java > 1446424 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1446424 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1446424 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1446424 > > Diff: https://reviews.apache.org/r/9175/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Ryota Egashira > >
