----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9626/#review17111 -----------------------------------------------------------
not clear how daylight saving is taken care of in the range calculation. comments/modifications will help. http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java <https://reviews.apache.org/r/9626/#comment36221> why not do for(instCount[0] = instCount[0] + end; instCount[0] >= instCount[0] + start; instCount[0]--) more readable in logic, and helps reduce 2 lines. - Mona Chitnis On Feb. 26, 2013, 8:06 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9626/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 8:06 p.m.) > > > Review request for oozie. > > > Description > ------- > > Use a currentRange function to move common code out of the loop and avoid CPU > cycles spent in initial instance and current(0) calculation. > > > This addresses bug OOZIE-1207. > https://issues.apache.org/jira/browse/OOZIE-1207 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1450366 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1450366 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/ParamChecker.java > 1450366 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-default.xml > 1450366 > > Diff: https://reviews.apache.org/r/9626/diff/ > > > Testing > ------- > > Current unit tests in CoordActionInputCheckXCommand cover the functionality. > No new unit tests added. > > > Thanks, > > Rohini Palaniswamy > >
