[ 
https://issues.apache.org/jira/browse/OOZIE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594976#comment-13594976
 ] 

jun aoki commented on OOZIE-1224:
---------------------------------

Matthew, 

1. if you have a code change with a trailing space it is bad
e.g. "public class SomeClass() " is bad "public class SomeClass()" is good

2. You should have a associated unit test for your change (in general). I guess 
in some cases making unit test case is not possible then you should communicate 
with the commiters?

3. When you do mvn compile and if you see more [WARNING] it is bad. and a new 
[WARNING] should not be introduced.



                
> web console user interface improvements
> ---------------------------------------
>
>                 Key: OOZIE-1224
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1224
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Matthew Ropp
>            Priority: Minor
>              Labels: console, newbie
>             Fix For: trunk
>
>         Attachments: patch.txt, patch.txt, patch.txt, patch.txt
>
>
> Have made several small changes to oozie-console.js to improve the UI:
> - remove width of main console screen so it will horizontally fill available 
> space
> - increase size of several Coord Job Info text fields to make them larger and 
> consistent
> - increase size of Job Info text fields so entire contents can be seen
> - when Coord Job Info or Job Info window is resized, stretch contents to match
> - capitalize field titles for "frequency" and "unit" in Coordinator Jobs grid
> - lengthen width of some columns in grid displays

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to