> On Feb. 26, 2013, 7:41 p.m., Virag Kothari wrote: > > Comments only on event generation > > > > -ActionCheckX failaction() should have wfjob failure event > > -CoordRerun should have waiting event for coordinator action > > -Remove coord action events from CoordKill, CoordSuspend, CoordResume. (All > > this are coord job related commands which will queue specific workflow > > commands. All the wf commands will call CoordActionUpdate once they finish > > execution. The events should be generated only there to avoid duplicates) > > -All coord action events should have nominal time > > -We can waiting events for CoordPushDependency and CoordActionUpdate also. > >
comments addressed > On Feb. 26, 2013, 7:41 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java, > > line 74 > > <https://reviews.apache.org/r/9602/diff/1/?file=262020#file262020line74> > > > > Have a different JPA executor which only brings required fields like > > user and app-name TODO in following iteration after virag puts up patch for the new JPAExecutors > On Feb. 26, 2013, 7:41 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java, > > line 67 > > <https://reviews.apache.org/r/9602/diff/1/?file=262029#file262029line67> > > > > CoordJob shouldn't be null. If it is, the event shouldn't be > > constructed as 'user' is a must field for an event. added Paramchecker.notnull which will error out if coordJob or coordAction is found to be null > On Feb. 26, 2013, 7:41 p.m., Virag Kothari wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java, > > line 86 > > <https://reviews.apache.org/r/9602/diff/1/?file=262034#file262034line86> > > > > I think we should not have wfaction error code and error message for a > > workflow job event. > > This can be done for a wf action event later. discussed offline with Virag. without any error code and msg, a WF job failure event is insufficient. The failed WF Action can be used to populate the error code and msg there. TODO in following iteration - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9602/#review17103 ----------------------------------------------------------- On March 5, 2013, 2:31 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9602/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 2:31 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1209 > WIP patch > > > This addresses bug OOZIE-1209. > https://issues.apache.org/jira/browse/OOZIE-1209 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1452586 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordinatorXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1452586 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionWaitingEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/Event.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/EventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/JobEventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/PersistentEventQueue.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/SLAEvent.java PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/SLAEventDispatcher.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobFailureEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobStartedEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/WorkflowJobSuccessEvent.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/CoordinatorEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyCoordEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/DummyWFEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/SLAEventListener.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/listener/WorkflowEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > PRE-CREATION > trunk/core/src/main/resources/oozie-default.xml 1452586 > trunk/core/src/test/java/org/apache/oozie/event/TestEventQueue.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9602/diff/ > > > Testing > ------- > > More unit tests to be added > > > Thanks, > > Mona Chitnis > >
