----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10593/#review19394 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/URIHandlerService.java <https://reviews.apache.org/r/10593/#comment40101> It will bloat up the logs. Can we remove it? trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java <https://reviews.apache.org/r/10593/#comment40102> Why is all this required? trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java <https://reviews.apache.org/r/10593/#comment40103> Services.get() can be used instead of using a local variable. Just one more assert can be added as part of previous test for /tmp/file instead of another test. Each test sets up service and destroy and adds time to the test run. - Rohini Palaniswamy On April 18, 2013, 1:20 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10593/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 1:20 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1331 > > > This addresses bug OOZIE-1331. > https://issues.apache.org/jira/browse/OOZIE-1331 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/service/URIHandlerService.java > 1469084 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1469084 > > trunk/core/src/test/java/org/apache/oozie/dependency/TestURIHandlerService.java > 1469084 > trunk/core/src/test/resources/coord-job-for-matd-relative.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/10593/diff/ > > > Testing > ------- > > Test cases added > > > Thanks, > > Virag Kothari > >
