[ 
https://issues.apache.org/jira/browse/OOZIE-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639769#comment-13639769
 ] 

Hadoop QA commented on OOZIE-1337:
----------------------------------

Testing JIRA OOZIE-1337

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 
132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1139
.    Tests failed: 7
.    Tests errors: 95

.    The patch failed the following testcases:

.      
testActionCheckTransientDuringLauncher(org.apache.oozie.command.wf.TestActionCheckXCommand)
.      
testActionCheckTransientDuringMRAction(org.apache.oozie.command.wf.TestActionCheckXCommand)
.      
testCoordActionRecoveryServiceForSubmitted(org.apache.oozie.service.TestRecoveryService)
.      
testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService)
.      
testCoordActionRecoveryServiceForSuspended(org.apache.oozie.service.TestRecoveryService)
.      testDoneFlagCreation(org.apache.oozie.TestCoordinatorEngine)
.      
testClientWithCustomAuthenticator(org.apache.oozie.servlet.TestAuthFilterAuthOozieClient)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/462/
                
> HadoopAccessorService has two static methods so you can't override them with 
> another implementation
> ---------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-1337
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1337
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: trunk
>
>         Attachments: OOZIE-1337.patch
>
>
> {{getMRDelegationTokenRenewer}} and {{getMRTokenRenewerInternal}} in 
> {{HadoopAccessorService}} are static; plus the {{JavaActionExecutor}} 
> accesses {{getMRDelegationTokenRenewer}} directly from 
> {{HadoopAccessorService}}.  So if you want to replace 
> {{HadoopAccessorService}} with your own version (via "oozie.services.ext" in 
> oozie-site), you can't re-implement those two methods.  
> There's also some {{private static final String}} constants that we should 
> make {{protected static final String}} constants.  
> And also a comment in the javadoc that says "The HadoopAccess class to use 
> can be configured in the oozie-site.xml using the 
> oozie.service.HadoopAccessorService.accessor.class property."  This isn't 
> true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to