[ 
https://issues.apache.org/jira/browse/OOZIE-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662063#comment-13662063
 ] 

James Kinley commented on OOZIE-891:
------------------------------------

I've had another look at this and now remember why I went down the 
{{Ext.data.PagingMemoryProxy}} route in the first place.

The top-level tabs for "Workflow Jobs", "Coordinator Jobs", and "Bundle Jobs" 
all call the {{V1JobsServlet}}, which appends the required paging tags to the 
end of the JSON (e.g. {{"len":5,"offset":2}}). 

For example, {{V1JobsServlet#getWorkflowJobs()}} does the following:

{code}
json.put(JsonTags.WORKFLOWS_JOBS, WorkflowJobBean.toJSONArray(jsonWorkflows, 
timeZoneId));
json.put(JsonTags.WORKFLOWS_TOTAL, jobs.getTotal());
json.put(JsonTags.WORKFLOWS_OFFSET, jobs.getStart());
json.put(JsonTags.WORKFLOWS_LEN, jobs.getLen());
{code}

Then in {{oozie-console.js}}, the following is added to the corresponding 
{{Ext.grid.GridPanel}}'s for paging:

{code}
bbar: getPagingBar(jobActionStatus)
{code}

The difficulty with the popups is that the JSON is returned for individual 
workflows|coordinators|bundles by the {{V1JobServlet}} and appending the 
required paging tags is not so straight forward. 

For example, to get the paging tags in for workflows, {{JsonWorkflowJob}} would 
have to be modified to A) take the start and length filters into consideration 
in {{toJSONObject()}} and B) know how many actions the workflow has in total 
(not just number of filtered actions). It's going to take me a little more time 
to work through this.


                
> Add pagination for all popup panels in Oozie Web UI
> ---------------------------------------------------
>
>                 Key: OOZIE-891
>                 URL: https://issues.apache.org/jira/browse/OOZIE-891
>             Project: Oozie
>          Issue Type: Bug
>          Components: coordinator
>    Affects Versions: 3.3.0
>            Reporter: Mona Chitnis
>            Assignee: James Kinley
>            Priority: Minor
>              Labels: patch
>             Fix For: trunk
>
>         Attachments: OOZIE-891.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to