----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11772/#review21648 -----------------------------------------------------------
testOozieDBCLI(org.apache.oozie.tools.TestOozieDBCLI) is failing trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java <https://reviews.apache.org/r/11772/#comment44739> Why change formatting? For 132 chars? I guess it is ok and to specify in a single line is what is followed if it is a JPA query. trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java <https://reviews.apache.org/r/11772/#comment44740> Is dropping and re-adding column not required for mysql and postgres? - Rohini Palaniswamy On June 10, 2013, 9:38 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11772/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 9:38 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1398 > > trying to solve following items > > 1 convert following to varchar/varchar2 on DB > > COORD_JOBS.SLA_XML > COORD_ACTIONS.SLA_XML > WF_JOBS.SLA_XML > WF_ACTIONS.SLA_XML > > WF_ACTIONS.ERROR_MESSAGE (Can add logic to truncate and store) > WF_ACTIONS.DATA (Max length for storing to this column is set to 2K in code > in places where it is populated with action data) > > 2. remove AUTH_token from DB and codebase, since not used. > > Candidates for removal: > BUNDLE_JOBS.AUTH_TOKEN > COORD_JOBS.AUTH_TOKEN > WORKFLOW_JOBS.AUTH_TOKEN > > > This addresses bug OOZIE-1398. > https://issues.apache.org/jira/browse/OOZIE-1398 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1491360 > trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1491360 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1491360 > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1491360 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1491360 > trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1491360 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1491360 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1491360 > > trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/client/rest/JsonWorkflowAction.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitHiveXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitPigXCommand.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitScriptLanguageXCommand.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/local/LocalOozie.java 1491360 > trunk/core/src/main/java/org/apache/oozie/service/BundleEngineService.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/service/CoordinatorEngineService.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/service/DagEngineService.java > 1491360 > > trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 1491360 > trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java > 1491360 > trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1491360 > trunk/core/src/test/java/org/apache/oozie/TestBundleJobBean.java 1491360 > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/TestCoordinatorJobBean.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1491360 > trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1491360 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleSubmitXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitHiveXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStartJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStatusJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > 1491360 > > trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java > 1491360 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1491360 > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1491360 > > Diff: https://reviews.apache.org/r/11772/diff/ > > > Testing > ------- > > Still WIP in terms of test/small bug fix, > but most of code change done, uploading initial patch. > > I did following tests so far > - run example workflow/coordinator, which works fine(tested because lots of > code changes to remove auth_token) > - DB upgrade test (ooziedb.sh upgrade) from 3.1 to 3.3 to 4.1 > - derby (hit one issue) > - mysql (works fine) > > currently doing oracle test. > > derby issue is that, it doesn't allow change column type from CLOB to VARCHAR > by 'ALTER TABLE COORD_JOBS ALTER COLUMN sla_xml SET DATA TYPE VARCHAR(255)" > > > Thanks, > > Ryota Egashira > >
