----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11884/#review21915 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java <https://reviews.apache.org/r/11884/#comment45210> Move this to within while block, so even if one listener fails, other proceeds. trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java <https://reviews.apache.org/r/11884/#comment45211> ahh..this was the issue trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java <https://reviews.apache.org/r/11884/#comment45212> the JPAExcecutor always throws E0603 on any exception. It would be better to change the JPA executor and use the getResultList() instead of fetchSingleResult() bcoz it doesn't throw exception. If there are no results, just return null and then check for null here. We do this in some other JPA executor - Virag Kothari On June 14, 2013, 7:23 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11884/ > ----------------------------------------------------------- > > (Updated June 14, 2013, 7:23 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1418 > > > This addresses bug OOZIE-1418. > https://issues.apache.org/jira/browse/OOZIE-1418 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1493209 > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1493209 > trunk/core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 1493209 > trunk/core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 1493209 > trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java 1493209 > trunk/core/src/main/java/org/apache/oozie/sla/service/SLAService.java > 1493209 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1493209 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1493209 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1493209 > > Diff: https://reviews.apache.org/r/11884/diff/ > > > Testing > ------- > > > Thanks, > > Mona Chitnis > >
