----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11912/#review22025 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java <https://reviews.apache.org/r/11912/#comment45342> add a //TODO here to use the JsonObject later on while instantiating trunk/core/src/main/resources/META-INF/persistence.xml <https://reviews.apache.org/r/11912/#comment45343> Can get rid of SLACalculatorBean entries from persistence.xml too - Mona Chitnis On June 17, 2013, 9:01 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11912/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 9:01 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1422 > > trying to merge JsonSLARegistrationEvent into SLARegistrationBean > also minor change in CoordActionsCountForJobIdJPAExecutor > > > This addresses bug OOZIE-1422. > https://issues.apache.org/jira/browse/OOZIE-1422 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/client/rest/sla/JsonSLARegistrationEvent.java > 1493822 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsCountForJobIdJPAExecutor.java > 1493822 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1493822 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1493822 > trunk/core/src/main/resources/META-INF/persistence.xml 1493822 > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1493822 > > Diff: https://reviews.apache.org/r/11912/diff/ > > > Testing > ------- > > locally run ooziedb.sh create -run, and checked schema is right, and examples > run fine. > now running all test cases > > > Thanks, > > Ryota Egashira > >