[
https://issues.apache.org/jira/browse/OOZIE-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716561#comment-13716561
]
Robert Kanter commented on OOZIE-1425:
--------------------------------------
Looks good.
Only one thing with the tests:
- When expecting an Exception, do some verification that it's the Exception you
were actually expecting and not a NPE or something else
And in the line with {{Integer.toString(Integer.parseInt(val));}}, is it
necessary to convert back to a String? If we just want to check that {{val}}
is an integer, shouldn't {{Integer.parseInt(val);}} be enough? (or are there
some edge cases such that both are required?)
> param checker should validate cron syntax
> -----------------------------------------
>
> Key: OOZIE-1425
> URL: https://issues.apache.org/jira/browse/OOZIE-1425
> Project: Oozie
> Issue Type: Sub-task
> Reporter: Bowen Zhang
> Assignee: Bowen Zhang
> Attachments: oozie-1425.patch, oozie-1425.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
