[
https://issues.apache.org/jira/browse/OOZIE-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733781#comment-13733781
]
Hadoop QA commented on OOZIE-1448:
----------------------------------
Testing JIRA OOZIE-1448
Cleaning local svn workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:red}-1{color} the patch seems to introduce 1 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1270
. Tests failed: 0
. Tests errors: 1
. The patch failed the following testcases:
.
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/698/
> A CoordActionUpdateXCommand gets queued for all workflows even if they were
> not launched by a coordinator
> ---------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-1448
> URL: https://issues.apache.org/jira/browse/OOZIE-1448
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: OOZIE-1448.patch, OOZIE-1448.patch, OOZIE-1448.patch,
> OOZIE-1448.patch
>
>
> Once a workflow (that wasn't started by a coordinator) ends, there's almost
> always a warning/error logged that looks like this:
> {noformat}
> 2013-07-09 16:16:54,711 WARN CoordActionUpdateXCommand:542 - USER[rkanter]
> GROUP[-] TOKEN[] APP[pig-wf] JOB[0000000-130709161625948-oozie-rkan-W]
> ACTION[-] E1100: Command precondition does not hold before execution, [,
> coord action is null], Error Code: E1100
> {noformat}
> The error is harmless, but it tends to confuse users who think that something
> went wrong. It also means that we have an extra unnecessary command in the
> queue for every workflow that wasn't started by a coordinator.
> In SignalXCommand, there is a line like this:
> {code:java}
> new CoordActionUpdateXCommand(wfJob).call(); //Note: Called even if wf is
> not necessarily instantiated by coordinator
> {code}
> The comment is part of the original code, and makes me think that this was
> done on purpose or perhaps when there wasn't a good way to check if a
> workflow was started by a coordinator?
> I think we can fix this by simply checking if the parent of {{wfJob}} is a
> coordinator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
