[ 
https://issues.apache.org/jira/browse/OOZIE-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737298#comment-13737298
 ] 

Hadoop QA commented on OOZIE-1463:
----------------------------------

Testing JIRA OOZIE-1463

Cleaning local svn workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:red}-1{color} the patch contains 73 line(s) longer than 132 
characters
.    {color:green}+1{color} the patch does adds/modifies 18 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1 BACKWARDS_COMPATIBILITY{color}
.    {color:red}-1{color} the patch seems to change 285 line(s) with JPA 
Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1271
.    Tests failed: 1
.    Tests errors: 1

.    The patch failed the following testcases:

.      testOozieDBCLI(org.apache.oozie.tools.TestOozieDBCLI)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/704/
                
> Remove discriminator column
> ---------------------------
>
>                 Key: OOZIE-1463
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1463
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>            Assignee: Virag Kothari
>         Attachments: OOZIE-1463.patch, OOZIE-1463.patch
>
>
> All workflow, coord and bundle tables have a discriminator column.
> {code}
> @DiscriminatorColumn(name = "bean_type", discriminatorType = 
> DiscriminatorType.STRING)
> {code}
> It is an extra column of no value. 
> Also, there is inheritance hierarchy where **ActionBean inherits JSON**Action.
> The JSON**Action also doesn't seem to add any value. We can have all the 
> columns of table, the corresponding setters and getters in one class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to