-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13612/
-----------------------------------------------------------
(Updated Aug. 23, 2013, 5:37 p.m.)
Review request for oozie.
Changes
-------
-replaced update statement of WRKJOB, WRKACTION, COORDJOB, COORDACTION,
BUNDLEJOB, BUNDLEACTION from non-test code
(currently cleaning up update in testcases to completely remove JPA Update
executors)
-modified API of query executors
-added test case for each query executor
one issue
-query cache doesn't work since Query keep entity manager internally, and if
it's already closed, it throw exception at the time of query execution, but
currently JPAservice create/close entity manager for each query execution, need
to think of workaround. query cache default to off now.
Bugs: OOZIE-1499
https://issues.apache.org/jira/browse/OOZIE-1499
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1499
this is *WIP*, still rough, just uploading for early review on design.
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1513182
trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BatchQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStartJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStatusJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionUpdateJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForModifiedTimeJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java
1513182
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLAEventQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java
PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java
1513182
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1513182
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
1513182
trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1513182
trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1513182
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBatchQueryExecutor.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStartJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStatusJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForModifiedTimeJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java
1513182
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java
PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/13612/diff/
Testing
-------
Thanks,
Ryota Egashira
