----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12973/#review25702 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/12973/#comment50206> Shouldn't delimiter be , ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java <https://reviews.apache.org/r/12973/#comment50207> Have something more than Xmx in this config trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java <https://reviews.apache.org/r/12973/#comment50208> Assert for the entire string instead of extracting heap size. trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java <https://reviews.apache.org/r/12973/#comment50205> Shouldn't it be A=foo,B=bar? - Rohini Palaniswamy On Aug. 29, 2013, 12:10 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12973/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2013, 12:10 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1372 > https://issues.apache.org/jira/browse/OOZIE-1372 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1372 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1518333 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1518333 > > Diff: https://reviews.apache.org/r/12973/diff/ > > > Testing > ------- > > -unit test against 2.2.0 > -ran example workflow (uber mode) in QE cluster with Hadoop 2.2.0, and > confirmed it succeeded and all job conf set properly > > > Thanks, > > Ryota Egashira > >
