> On Aug. 29, 2013, 12:14 a.m., Rohini Palaniswamy wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/ZKLocksService.java, > > line 107 > > <https://reviews.apache.org/r/11922/diff/9-11/?file=340664#file340664line107> > > > > Does this mean the zk node is /locks/<resource> or it is > > /oozie.zookeeper.namespace/locks/<resource> ? From the looks of it, it > > seems it is /locks/<resource> unless there is a base path maintained in zk.
It's /oozie.zookeeper.namespace/locks/<resource>. Curator (unless its ZK itself, I'm not sure) automatically prepends the namespace to all paths, even here where its not obvious that its doing that. I also double-checked with the zookeeper cli to make sure. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11922/#review25700 ----------------------------------------------------------- On Aug. 20, 2013, 11:30 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11922/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 11:30 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-615 > https://issues.apache.org/jira/browse/OOZIE-615 > > > Repository: oozie > > > Description > ------- > > See this comment for details: > https://issues.apache.org/jira/browse/OOZIE-615?focusedCommentId=13686181&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13686181 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1515680 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1515680 > /trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1515680 > /trunk/core/pom.xml 1515680 > /trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/command/Command.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/lock/LockToken.java PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/lock/MemoryLocks.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java > 1515680 > > /trunk/core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > 1515680 > > /trunk/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/service/PauseTransitService.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1515680 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/service/XLogService.java 1515680 > > /trunk/core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/ZKLocksService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > 1515680 > /trunk/core/src/main/java/org/apache/oozie/util/ConfigUtils.java 1515680 > > /trunk/core/src/main/java/org/apache/oozie/util/FixedJsonInstanceSerializer.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/MemoryLocks.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/util/MultiFileReader.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/XLogReader.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1515680 > /trunk/core/src/main/java/org/apache/oozie/util/ZKUtils.java PRE-CREATION > /trunk/core/src/main/resources/oozie-default.xml 1515680 > > /trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1515680 > /trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java > 1515680 > /trunk/core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/DummyLogStreamingServlet.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java > 1515680 > > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1515680 > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1515680 > /trunk/core/src/test/java/org/apache/oozie/test/ZKXTestCase.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java > 1515680 > /trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java > 1515680 > /trunk/core/src/test/java/org/apache/oozie/util/TestMultiFileReader.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1515680 > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1515680 > /trunk/core/src/test/java/org/apache/oozie/util/TestZKUtils.java > PRE-CREATION > /trunk/distro/src/main/tomcat/ssl-web.xml 1515680 > /trunk/docs/src/site/twiki/AG_Install.twiki 1515680 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1515680 > /trunk/docs/src/site/twiki/WebServicesAPI.twiki 1515680 > /trunk/pom.xml 1515680 > > Diff: https://reviews.apache.org/r/11922/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
