> On Sept. 5, 2013, 4:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BatchQueryExecutor.java, > > lines 62-65 > > <https://reviews.apache.org/r/13612/diff/7/?file=348070#file348070line62> > > > > Can remove the services != null check and do the get in a single line. > > Applicable to other query executor classes also.
without this null check, it caused exception in test case. > On Sept. 5, 2013, 4:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java, > > line 197 > > <https://reviews.apache.org/r/13612/diff/7/?file=348091#file348091line197> > > > > Will have to check whether this condition is correct when we get to > > select queries. There will be cases where it can be null or empty yes will rethink in SELECT query patch. > On Sept. 5, 2013, 4:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java, line 409 > > <https://reviews.apache.org/r/13612/diff/7/?file=348102#file348102line409> > > > > Will there be cases where we have to throw NoResultException back? yes it could be the case, and when it happens, exception thrown, but we don't want exception to be thrown since each query executor is supposed to handle the case where no matched result appropriately, > On Sept. 5, 2013, 4:53 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java, line 416 > > <https://reviews.apache.org/r/13612/diff/7/?file=348102#file348102line416> > > > > Does jpa need a commit for get calls? current code does commit for any type of query - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13612/#review25665 ----------------------------------------------------------- On Sept. 6, 2013, 10:48 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13612/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 10:48 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1499 > https://issues.apache.org/jira/browse/OOZIE-1499 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1499 > > this is *WIP*, still rough, just uploading for early review on design. > > > too many file changes in this patch, to help review, describing a bit on > design. > main part is query executor. > > QueryExecutor> > -provides basic API to run query (update query-->executeUpdate(), select > query --> get() or getList()) > -each table (wrk job/action, coord job/action, bundle job/action, sla...) > has it's own implementation of query executor. also there is > BatchQueryExecutor which allow mutiple queries to run in one transaction. > -construct query based on namedQuery name (defined in each Bean), and does > cache for performance enhancement > > How to run query> > currently we instantiate corresponding JPA executor every time, but instead > it's changed to access QueryExecutor and pass namedQuery as argument . > for example, > - jpaService.execute(new > CoordActionUpdateForInputCheckJPAExecutor(action)); > + > CoordActionQueryExecutor.getInstance().executeUpdate(CoordActionQuery.UPDATE_COORD_ACTION_FOR_INPUTCHECK, > action); > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1520080 > trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1513647 > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1514458 > trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1513647 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1513647 > trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1520080 > trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundlePauseXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleUnpauseXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionMaterializeCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1516659 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPauseXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java > 1516892 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordUnpauseXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/ResumeXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BatchQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateDeleteJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStartJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertForCoordActionStatusJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForModifiedTimeJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdatePushInputCheckJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateStatusJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobUpdateJPAExecutor.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLACalculationInsertUpdateJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryUpdateForSLAStatusActualTimesJPAExecutor.java > 1520080 > > trunk/core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > 1518739 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1513647 > trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1520080 > trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java > 1520080 > trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1520080 > trunk/core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsKillXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBatchQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateDeleteJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStartJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertForCoordActionStatusJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForModifiedTimeJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetFromParentIdJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLARegistrationQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLASummaryQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsCountNotForPurgeFromWorkflowParentIdJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculationJPAExecutor.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > 1520080 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetRecordsOnRestartJPAExecutor.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java 1520080 > > trunk/core/src/test/java/org/apache/oozie/sla/TestSLASummaryGetOnRestartJPAExecutor.java > 1520080 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1520080 > trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1520080 > > Diff: https://reviews.apache.org/r/13612/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
