----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14117/#review26080 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java <https://reviews.apache.org/r/14117/#comment50910> Can we just reuse E0100(XLog.OPS, "Could not initialize service [{0}], {1}"), instead of introducing another one. trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java <https://reviews.apache.org/r/14117/#comment50909> Pass the permission also as argument to recursiveChangePermissions instead of doing FsPermission.valueOf(PERMISSION_STRING) inside the method everytime - Rohini Palaniswamy On Sept. 13, 2013, 12:39 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14117/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 12:39 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1528 > https://issues.apache.org/jira/browse/OOZIE-1528 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1528 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1521980 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521980 > trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521980 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > 1521980 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java > 1521980 > trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521980 > trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > 1521980 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java > 1521980 > > Diff: https://reviews.apache.org/r/14117/diff/ > > > Testing > ------- > > > Thanks, > > Virag Kothari > >
