> On Sept. 13, 2013, 7:44 p.m., Rohini Palaniswamy wrote: > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java, > > line 64 > > <https://reviews.apache.org/r/14129/diff/1/?file=352024#file352024line64> > > > > Don't need to declare exception message as a string. Just use that in > > the exception constructor directly
Using it multiple places, for logging and throwing exception. So defining it helps, as I don't have to change it multiple places. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14129/#review26092 ----------------------------------------------------------- On Sept. 13, 2013, 10:10 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14129/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 10:10 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1529 > https://issues.apache.org/jira/browse/OOZIE-1529 > > > Repository: oozie > > > Description > ------- > > 1.Disabling job DAG display for workflow having action > 25. > Job DAQ rendering happens at server side. It's a heavy operation and server > goes OOM while generating DAG for workflow having more actions. > > 2. There are other UI fixes. > a.)Client calls to generates DAG two times, 1> while initializing panel. 2> > When user clicks Job DAG tab. > Disabling the DAG generation while initializing panel. It will be called > only when user clicks Job DAG panel. > > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 1520065 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java > 1520065 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java > 1520065 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/graphWF_26_state.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js > 1520065 > > Diff: https://reviews.apache.org/r/14129/diff/ > > > Testing > ------- > > Added three test case. > 1. If actions<25, should generate graph > 2. If actions=25, should generate graph > 3. If actions>25, should throw error message. > > > Thanks, > > Purshotam Shah > >
