[
https://issues.apache.org/jira/browse/OOZIE-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806986#comment-13806986
]
Alejandro Abdelnur commented on OOZIE-1589:
-------------------------------------------
+1
> TestZKLocksService is flakey
> ----------------------------
>
> Key: OOZIE-1589
> URL: https://issues.apache.org/jira/browse/OOZIE-1589
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: OOZIE-1589.patch
>
>
> TestZKLocksService is highly dependent on the order of things happening
> because its testing locks. I've seen tests in this class fail a number of
> times with messages like this:
> {noformat}
> expected:<a:[1-L a:2-L a:1-U] a:2-U> but was:<a:[2-L a:1-L] a:2-U>
> {noformat}
> which is because things happened in a slightly different order than it was
> expecting (though everything is happening correctly)
> When I created these tests, I just took the TestLockService and made it use
> ZKLocks instead of MemoryLocks. The ZKLocks take longer to lock than the
> MemoryLocks, so the timings are sometimes too fast. I think we just need to
> increase the sleep calls, and use the {{sleep()}} method instead of
> {{Thread.sleep()}} so it will scale with the "waitfor ratio" on slower
> machines.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
