[
https://issues.apache.org/jira/browse/OOZIE-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825581#comment-13825581
]
Robert Kanter commented on OOZIE-1612:
--------------------------------------
Looks good.
Just two minor things:
# No need to catch the {{ParseException}}; just make {{testXLogFormatDate}}
throw {{Exception}}. If there is a {{ParseException}}, then the test will fail
and the stack trace will be printed out automatically
# Also no need for the empty {{finally}} blocks
> When printing Dates to log messages, we should make sure they are in
> oozie.processing.timezone
> ----------------------------------------------------------------------------------------------
>
> Key: OOZIE-1612
> URL: https://issues.apache.org/jira/browse/OOZIE-1612
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Robert Kanter
> Priority: Minor
> Labels: newbie
> Attachments: OOZIE-1612.patch
>
>
> We were recently looking into an issue and noticed that the same log message
> had printed different date objects with different timezones, which makes it
> hard to compare the two. Which leads to the bigger picture, which is that we
> should be printing any Date objects in log messages with the
> {{oozie.processing.timezone}} timezone (there's a method for that in
> {{DateUtils}}).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
