> On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote: > >
thanks for review > On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote: > > trunk/webapp/src/main/webapp/oozie-console.js, line 100 > > <https://reviews.apache.org/r/15276/diff/1/?file=379576#file379576line100> > > > > If it check null, then it's fine. yes, it checks null > On Nov. 18, 2013, 8:23 p.m., Purshotam Shah wrote: > > trunk/webapp/src/main/webapp/oozie-console.js, line 1764 > > <https://reviews.apache.org/r/15276/diff/1/?file=379576#file379576line1764> > > > > We should > > parametrize(;status=SUCCEEDED;status=KILLED;status=FAILED;status=DONEWITHERROR'). > > But considering current state, it' ok. we should plan to refactor. parametrized long string. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15276/#review29068 ----------------------------------------------------------- On Nov. 6, 2013, 6:31 p.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15276/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 6:31 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1605 > https://issues.apache.org/jira/browse/OOZIE-1605 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1605 > > > Diffs > ----- > > trunk/webapp/src/main/webapp/oozie-console.js 1538031 > > Diff: https://reviews.apache.org/r/15276/diff/ > > > Testing > ------- > > locally tested > > > Thanks, > > Ryota Egashira > >
