----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15605/#review29069 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/15605/#comment56150> sharelibupdate. Other options like queuedump systemmode do not use camel case. We have to keep it consistent Also since it is a option, can you name it as UPDATE_SHARELIB_OPTION to maintain consistency http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/15605/#comment56148> shareliblist Also since it is a option, can you name it as LIST_SHARELIB_OPTION http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/15605/#comment56154> Update server to use a newer version of sharelib http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/15605/#comment56151> sharelibList. List available sharelib directories that can be specified in a workflow action http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/15605/#comment56156> Class names should start with upper case http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/15605/#comment56157> private static http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/15605/#comment56174> Better message to user please http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/15605/#comment56158> private static http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/15605/#comment56175> Better message http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15605/#comment56179> queue? http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15605/#comment56185> trimming path not done here. Actually the path values are not put and only keys are put here http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15605/#comment56183> Send the base sharelib directory also in json response and print it to the user as the list trims the paths http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15605/#comment56200> You should not be doing trimming. Put the full path of the files http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java <https://reviews.apache.org/r/15605/#comment56188> Better json response with tagging should be done. For eg: host, status, new_sharelib. Also add a parent tag so that it is extensible later http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56194> available sharelib http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56195> If the name of the sharelib is passed as an argument (regex supported) then all corresponding files are also listed. http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56193> Print sharelib base directory http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56197> hdfs://user/oozie/sharelib/pig/pig.jar hdfs://user/oozie/sharelib/pig/piggybank.jar http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56191> This command makes the oozie server or all oozie servers in case of HA to pick up the latest version of sharelib present under oozie.service.WorkflowAppService.system.libpath directory based on the sharelib directory timestamp. This command is used to update the sharelib on the oozie server without requiring a restart when newer versions of pig, hive, etc are available. http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56198> Give headers- host, status http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/15605/#comment56192> Print the location of the new sharelib picked up as well http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15605/#comment56203> spell check. query parameter lib is used http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15605/#comment56201> Response should be an array http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15605/#comment56202> Keep a common json for shareliblist with different tags when key is specified or not. http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15605/#comment56196> Add a additional files tag http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/15605/#comment56199> successful - Rohini Palaniswamy On Nov. 15, 2013, 11:12 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15605/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 11:12 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1519 > https://issues.apache.org/jira/browse/OOZIE-1519 > > > Repository: oozie > > > Description > ------- > > Also include fixes of (OOZIE-1611) Oozie CLI and Rest command to list > supported sharelib > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/ShareLibService.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_CommandLineTool.twiki > 1542384 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/WebServicesAPI.twiki > 1542384 > > Diff: https://reviews.apache.org/r/15605/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
