[ 
https://issues.apache.org/jira/browse/OOZIE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829512#comment-13829512
 ] 

Robert Kanter commented on OOZIE-1575:
--------------------------------------

A couple of things:
# Instead of shoehorning the {{SubmitSqoopXCommand}} as a subclass of 
{{SubmitScriptLanguageXCommand}} to inherit some of its methods, I think we 
should move those methods up to {{SubmitHttpXCommand}} and have 
{{SubmitSqoopXCommand}} subclass it.  Sqoop doesn't take a script, and if we 
add other commands in the future such as DistCp, then we don't want to make 
them subclasses of {{SubmitScriptLanguageXCommand}} as well.
# In {{SubmitSqoopXCommand#generateSection}}, the {{otherArgs}} variable never 
makes it into the generated workflow

> Add functionality to sumbit sqoop job through http on oozie server side
> -----------------------------------------------------------------------
>
>                 Key: OOZIE-1575
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1575
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Bowen Zhang
>            Assignee: Bowen Zhang
>             Fix For: trunk
>
>         Attachments: oozie-1575.patch, oozie-1575.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to