[
https://issues.apache.org/jira/browse/OOZIE-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated OOZIE-1612:
--------------------------------
Attachment: oozie-1612.2.patch
I didn't find an efficient way to format Date objects within XLog.
In addition, I noticed that my previous patch would only correct timezone if
formatting template is used for logging. In 100% of the places where Dates are
logged, templates are not used - instead the Date objects are concatenated into
a string and then logged. Which means the formatter will never be called and
the wrong timezone will be used.
So, attaching the ugly patch: multiple locations where Dates are logged are
converted to Oozie timezone. And one location with a comment explaining why I
chose not to convert :)
> When printing Dates to log messages, we should make sure they are in
> oozie.processing.timezone
> ----------------------------------------------------------------------------------------------
>
> Key: OOZIE-1612
> URL: https://issues.apache.org/jira/browse/OOZIE-1612
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Robert Kanter
> Priority: Minor
> Labels: newbie
> Attachments: OOZIE-1612.1.patch, OOZIE-1612.patch, oozie-1612.2.patch
>
>
> We were recently looking into an issue and noticed that the same log message
> had printed different date objects with different timezones, which makes it
> hard to compare the two. Which leads to the bigger picture, which is that we
> should be printing any Date objects in log messages with the
> {{oozie.processing.timezone}} timezone (there's a method for that in
> {{DateUtils}}).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
